gh-137007: Track executor before any possible deallocations #137016
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fidget-Spinner
requested review from
brandtbucher
and removed request for
markshannon
Fidget-Spinner
commented
Jul 22, 2025
| executor->vm_data.warm = true; | ||
| if (_PyJIT_Compile(executor, executor->trace, length)) { | ||
| Py_DECREF(executor); | ||
| return NULL; |
There was a problem hiding this comment.
Note to reviewers: the bad dealloc happens right above this line at line 1233/1238 depending on which diff you view.
|
There's no reproducer because I can't force _PyJIT_Compile to fail except in specific scenarios, or when the GC decides to kick in right when the executor is linked, but not yet tracked. |
|
Unfortunately the patch doesn't fix the issue for me. I double checked that it's applied and still get the abort. Investigating whether the diff necessary to reproduce is the same. |
…/cpython into track-before-deallocating
|
@devdanzin can you please try again? |
|
Still aborting here. Does it stop reproducing for you? |
picnixz
reviewed
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.