Skip to content

Conversation

yoney
Copy link
Contributor

@yoney yoney commented Sep 2, 2025

This is a placeholder PR to mark the termios module as audited in gh-116738 for thread safety in the free-threading build.

  • The POSIX functions used by termios are marked as MT-Safe in the Linux termios(3). There are no thread safety issues noted in the POSIX documentation.
  • The current CPython implementation wraps posix functions with Py_BEGIN_ALLOW_THREADS and Py_END_ALLOW_THREADS which assumes they are thread-safe.
  • Additionally, the module tests were run under thread-sanitizer, which did not report any errors.

cc: @mpage @colesbury @Yhg1s

Note: This PR will be closed after termios is marked in gh-116738

@bedevere-app bedevere-app bot added the docs Documentation in the Doc dir label Sep 2, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Sep 2, 2025
@yoney yoney marked this pull request as ready for review September 2, 2025 18:39
@vstinner
Copy link
Member

vstinner commented Sep 3, 2025

This is a placeholder PR to mark the termios module as audited

I don't understand the purpose of this PR. If no code change is needed, I suggest closing the PR.

@yoney
Copy link
Contributor Author

yoney commented Sep 3, 2025

This is a placeholder PR to mark the termios module as audited

I don't understand the purpose of this PR. If no code change is needed, I suggest closing the PR.

@vstinner Thank you for your feedback! Sorry for any confusion, my intention wasn’t to land this diff. I created this PR mainly as a placeholder to mark the termios module as audited in gh-116738. I added a note to the description, but I realise it might not be visible at the end. Could you please mark termios? I’ll go ahead and close this PR.

Thanks again!

@yoney yoney closed this Sep 3, 2025
@yoney yoney deleted the ft_termios branch October 19, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants