Skip to content

gh-138729: Cover inspect.formatannotationrelativeto with tests #138730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 10, 2025
Merged

gh-138729: Cover inspect.formatannotationrelativeto with tests #138730

merged 3 commits into from
Sep 10, 2025
+42 −1

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 10, 2025 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 10, 2025
@bedevere-app bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Sep 10, 2025
@sobolevn sobolevn changed the title gh-1387729: Cover inspect.formatannotationrelativeto with tests gh-138729: Cover inspect.formatannotationrelativeto with tests Sep 10, 2025
@bedevere-app bedevere-app bot mentioned this pull request Sep 10, 2025
Open
serhiy-storchaka
serhiy-storchaka reviewed Sep 10, 2025
View reviewed changes
serhiy-storchaka
serhiy-storchaka reviewed Sep 10, 2025
View reviewed changes
serhiy-storchaka
serhiy-storchaka approved these changes Sep 10, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@sobolevn
Copy link
Member Author

@serhiy-storchaka thank you for your guidance, great review as always!

@sobolevn sobolevn merged commit f5fa336 into python:main Sep 10, 2025
47 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2025
@sobolevn @miss-islington
pythongh-138729: Cover inspect.formatannotationrelativeto with tests (
98a2e27 
pythonGH-138730)

(cherry picked from commit f5fa336)

Co-authored-by: sobolevn <mail@sobolevn.me>
@miss-islington-app
Copy link

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f5fa336579d124e389b1c36a5431e7908aaf5e53 3.13

@bedevere-app
Copy link

bedevere-app bot commented Sep 10, 2025

GH-138747 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 10, 2025
sobolevn added a commit to sobolevn/cpython that referenced this pull request Sep 10, 2025
@sobolevn
[3.13] pythongh-138729: Cover inspect.formatannotationrelativeto wi…
7e92ecd 
…th tests (pythonGH-138730)

(cherry picked from commit f5fa336)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Sep 10, 2025

GH-138748 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 10, 2025
sobolevn added a commit that referenced this pull request Sep 10, 2025
@sobolevn
[3.13] gh-138729: Cover inspect.formatannotationrelativeto with tes…
2422e81 
…ts (GH-138730) (#138748)

(cherry picked from commit f5fa336)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@sobolevn sobolevn

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @serhiy-storchaka