gh-128067: Fix pyrepl overriding printed output without newlines #138732
+44
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried a bit to debug this and narrowed it down to these two lines for windows and unix terminals respectively:
Because while properly running the repl in unix doesnt cause the issue, running the test i added also fails there before these changes.
I am not 100% sure if this is the base and 100% correct way, but it causes the test to pass on unix and fixes the issue on windows for me.
I also attempted to try to be able to run these tests for windows (because thats where we actually saw the issue) but didnt manage unfortunately.
With the fix in the unix console:
Without: