fix: Add better error message for case without match#138861
Closed
raman118 wants to merge 1 commit intopython:mainfrom
Closed
fix: Add better error message for case without match#138861raman118 wants to merge 1 commit intopython:mainfrom
raman118 wants to merge 1 commit intopython:mainfrom
Conversation
|
The following commit authors need to sign the Contributor License Agreement: |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added better error messaging for the case when a
casestatement is used outside of amatchstatement.Changes Made
E_INVALID_CASE_OUTSIDE_MATCHto handle this specific syntax errorparser_error_msgfunction to use this new code when a case statement is found outside a match statementProblem Solved
Before this change, users would see a generic "invalid syntax" error when accidentally using a
casestatement outside of amatchstatement. This provided little guidance on how to fix the issue.After this change, users will see the more descriptive error message "case statement must be inside match statement", which clearly indicates what needs to be fixed.
Type of Change
Testing
test_grammar.pyto verify the new error message is displayed correctlyChecklist
Fixes gh-138857