gh-73045 Fixed behaviour of os.path.ismount(), for Windows, for non-existent drives and paths #139907
+39
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for mounted volume
Attempting to to casefold() and compare in a single line results in AttributeError being raised during testing with test_ntpath.py
Added newline at end of News entry. Removed trailing whitespace on comment in test_ntpath.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Windows, os.path.ismount() now returns False, instead of raising FileNotFoundError for paths on drives that don't exist. Also now returns False for non-existent drive roots.
Tests for the new behaviour are included in test_ntpath.py.
Documentation updated to clarify that existent drive roots are mount points.
News entry added.
📚 Documentation preview 📚: https://cpython-previews--139907.org.readthedocs.build/