Skip to content

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Oct 11, 2025

Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I'm not sure I see the value of this. Then again, I didn't see the logic of withdrawing the "make zlib required" PEP... Particularly given that ensurepip (and pip) are not used or functional on WASI (the key platform withlout zlib), it feels like making ensurepip more friendly for zlib-less builds of Python is pretty pointless.

But equally, it's not a big burden to add this test, so I'm not going to object (beyond the request for a clarifying comment in the test code that I included below).

@bedevere-app
Copy link

bedevere-app bot commented Oct 11, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Oct 11, 2025

I didn't see the logic of withdrawing the "make zlib required" PEP...

I think we can leave PEP-775 for a different discussion.

Particularly given that ensurepip (and pip) are not used or functional on WASI (the key platform withlout zlib), it feels like making ensurepip more friendly for zlib-less builds of Python is pretty pointless.

I think this error message is not for WASI, but for people who unintentionally built Python without zlib, or omitted it but wish to use ensurepip and are surprised by the long error message they receive (an example would be the linked issue).

This proposal also received support on the linked issue (3 thumbs up).


I will improve the comment in the test, apologies for the confusion it caused.

@StanFromIreland
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Oct 12, 2025

Thanks for making the requested changes!

@pfmoore: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from pfmoore October 12, 2025 17:39
@encukou encukou merged commit 1a82568 into python:main Oct 13, 2025
50 of 53 checks passed
@StanFromIreland StanFromIreland deleted the ensurepip-zlib branch October 13, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants