-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
gh-139823: Check if zlib
is available in ensurepip
#139954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I'm not sure I see the value of this. Then again, I didn't see the logic of withdrawing the "make zlib required" PEP... Particularly given that ensurepip
(and pip
) are not used or functional on WASI (the key platform withlout zlib), it feels like making ensurepip more friendly for zlib-less builds of Python is pretty pointless.
But equally, it's not a big burden to add this test, so I'm not going to object (beyond the request for a clarifying comment in the test code that I included below).
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I think we can leave PEP-775 for a different discussion.
I think this error message is not for WASI, but for people who unintentionally built Python without zlib, or omitted it but wish to use This proposal also received support on the linked issue (3 thumbs up). I will improve the comment in the test, apologies for the confusion it caused. |
I have made the requested changes; please review again |
Thanks for making the requested changes! @pfmoore: please review the changes made to this pull request. |
make install
fails inensurepip
if zlib extension is missing #139823