Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-37223: test_io: silence destructor errors #14031

Merged
merged 3 commits into from
Jun 12, 2019
Merged

[3.8] bpo-37223: test_io: silence destructor errors #14031

merged 3 commits into from
Jun 12, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 12, 2019 •
edited by bedevere-bot
Loading

vstinner added 3 commits June 13, 2019 00:01
@vstinner
bpo-18748: Fix _pyio.IOBase destructor (closed case) (GH-13952)
c7c6582 
_pyio.IOBase destructor now does nothing if getting the closed
attribute fails to better mimick _io.IOBase finalizer.

(cherry picked from commit 4f6f7c5)
@vstinner
bpo-37223: test_io: silence destructor errors (GH-13954)
1a20871 
Implement also MockNonBlockWriterIO.seek() method.

(cherry picked from commit b589cef)
@vstinner
bpo-37223, test_io: silence last 'Exception ignored in:' (GH-14029)
fdc4855 
Use catch_unraisable_exception() to ignore 'Exception ignored in:'
error when the internal BufferedWriter of the BufferedRWPair is
destroyed. The C implementation doesn't give access to the
internal BufferedWriter, so just ignore the warning instead.

(cherry picked from commit 913fa1c)
@vstinner vstinner merged commit c15a682 into python:3.8 Jun 12, 2019
@vstinner vstinner deleted the test_io_silence38 branch June 12, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot