gh-57665: Remove 'response_class' from getresponse docstring.#140707
Merged
orsenthil merged 1 commit intopython:mainfrom Oct 31, 2025
Merged
Conversation
This variable is not documented as part of the API in the standard library documentation; it should be considered as an implementation detail and as such should not be included in the doc string. Closes python#57665.
bitdancer
changed the title
bitdancer
changed the title
orsenthil
approved these changes
Oct 31, 2025
Member
orsenthil
left a comment
orsenthil
left a comment
There was a problem hiding this comment.
LGTM. The reasoning is fine.
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
…ython#140707) Remove 'response_class' from getresponse docstring. This variable is not documented as part of the API in the standard library documentation; it should be considered as an implementation detail and as such should not be included in the doc string. Closes python#57665.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This variable is not documented as part of the API in the standard
library documentation; it should be considered as an implementation
detail and as such should not be included in the doc string.
Closes #57665.