gh-140826: Remove the wrong documents about comparison behavior on winreg.HKEYType#140840
Closed
aisk wants to merge 2 commits intopython:mainfrom
Closed
gh-140826: Remove the wrong documents about comparison behavior on winreg.HKEYType#140840aisk wants to merge 2 commits intopython:mainfrom
aisk wants to merge 2 commits intopython:mainfrom
Conversation
aisk
added
skip news
needs backport to 3.13
Member
|
Please rebase this on 3.14. |
Comment on lines
-774
to
-776
| The object also support equality comparison semantics, so handle objects will | ||
| compare equal if they both reference the same underlying Windows handle value. | ||
| Closed handle objects (those with a handle value of zero) always compare equal. |
Member
There was a problem hiding this comment.
This should only be removed in 3.14, isn't?
Please rebase the branch on 3.14 (in Git and in the GitHub interface) or create a new PR for 3.14.
aisk
force-pushed
the
hkey-compare-doc
branch
from
45fb260 to
69bc853
Compare
aisk
requested review from
AA-Turner,
AlexWaygood,
FFY00,
JelleZijlstra,
berkerpeksag,
cjw296,
emmatyping,
ethanfurman,
gpshead,
jaraco,
kumaraditya303 and
vsajip
as code owners
aisk
removed request for
AA-Turner,
AlexWaygood,
Eclips4,
FFY00,
Fidget-Spinner,
ZeroIntensity,
brandtbucher,
corona10,
emmatyping,
erlend-aasland,
ethanfurman,
ezio-melotti,
gaogaotiantian,
isidentical,
kumaraditya303,
lysnikolaou,
markshannon,
pablogsal,
pganssle,
picnixz,
pradyunsg,
rhettinger,
savannahostrowski,
sethmlarson,
terryjreedy,
tomasr8 and
willingc
Member
Author
|
Sorry, I just messed things up. I was trying to rebase this change onto the 3.14 branch, but there were too many conflicts. GitHub may have thought I reverted all the changes between this commit (around the main branch) and 3.14, and automatically requested all the code owners whose files were affected as reviewers 😂 Really sorry for making such a noise. Will close this PR and make a new PR based on 3.14 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
winreg.HKEYTypeis inconsistent with its documentation #140826📚 Documentation preview 📚: https://cpython-previews--140840.org.readthedocs.build/