Skip to content

gh-141808: Don't remove the JIT stencils when building with PGO #141809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 5 commits into from
Dec 9, 2025
Merged

gh-141808: Don't remove the JIT stencils when building with PGO #141809

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a2c21db
gh-141808: Don't remove the JIT stencils when building with PGO
hroncok Nov 20, 2025
3d969c6
Fix typo in Misc/NEWS.d/next/Build/2025-11-20-23-15-39.gh-issue-14180…
hroncok Nov 21, 2025
24075b3
Have a separate clean-jit-stencils make target
hroncok Nov 27, 2025
349a92e
Have a separate clean-profile make target
hroncok Nov 27, 2025
a3dbb59
fixup! Have a separate clean-profile make target
hroncok Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile.pre.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3239,7 +3239,6 @@ clean-retain-profile: pycremoval
-rm -rf Python/deepfreeze
-rm -f Python/frozen_modules/*.h
-rm -f Python/frozen_modules/MANIFEST
-rm -f jit_stencils*.h
-find build -type f -a ! -name '*.gc??' -exec rm -f {} ';'
-rm -f Include/pydtrace_probes.h
-rm -f profile-gen-stamp
Expand Down Expand Up @@ -3290,6 +3289,8 @@ distclean: clobber docclean
Modules/ld_so_aix Modules/python.exp Misc/python.pc \
Misc/python-embed.pc Misc/python-config.sh
-rm -f python*-gdb.py
# gh-141808: The JIT stencils are deliberately kept in make clean(-retain-profile)
-rm -f jit_stencils*.h
# Issue #28258: set LC_ALL to avoid issues with Estonian locale.
# Expansion is performed here by shell (spawned by make) itself before
# arguments are passed to find. So LC_ALL=C must be set as a separate
Expand Down
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Build/2025-11-20-23-15-39.gh-issue-141808.NEewZC.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
When running ``make clean`` or ``make clean-retain-profile``, keep the
genearted JIT stencils. That way, the stencils are not genearted twice when
Profile-guided optimization (PGO) is used. It also allows distributors to
supply their own pre-built JIT stencils.
Loading