bpo-37346: Use OSError subclasses in os documentation #14262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangrisano
suggested changes
Jun 20, 2019
| the renaming will be an atomic operation (this is a POSIX requirement). On | ||
| Windows, if *dst* already exists, :exc:`OSError` will be raised even if it is a | ||
| file. | ||
| Rename the file or directory *src* to *dst*. If *dst* exists, the operation |
There was a problem hiding this comment.
Double space after stop.
There was a problem hiding this comment.
Hi @mangrisano, Thanks for taking the time to review this PR. One or two spaces after a period are both acceptable in Python documentation [devguide reference].
There was a problem hiding this comment.
Ah ok, thank for clarifying me that.
| :exc:`IsADirectoryError` or a :exc:`NotADirectoryError` will be raised | ||
| respectively. If both are directories and *dst* is empty, *dst* will be | ||
| silently replaced. If *dst* is a non-empty directory, an :exc:`OSError` | ||
| is raised. If both are files, *dst* it will be replaced silently if the user |
There was a problem hiding this comment.
Double space after stop.
|
I'm not quite clear what the status is. Should I switch to double-spaces, or is this just waiting for core review? |
asvetlov
approved these changes
Jul 5, 2019
asvetlov
added
needs backport to 3.7
needs backport to 3.8
|
GH-14596 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 5, 2019
(cherry picked from commit a55f75a) Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
|
GH-14597 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 5, 2019
(cherry picked from commit a55f75a) Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Jul 5, 2019
(cherry picked from commit a55f75a) Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Jul 5, 2019
(cherry picked from commit a55f75a) Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
zware
reviewed
Jul 11, 2019
|
|
||
| On Windows, if *dst* exists a :exc:`FileExistsError` is always raised. | ||
|
|
||
| On Unix, if *src* is a file and *dst* is a directory or vice-versa, anq:q |
There was a problem hiding this comment.
bpo-37554 points out the errant vim exit at the end of this line :)
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
ronaldoussoren
added a commit
to ronaldoussoren/cpython
that referenced
this pull request
Nov 18, 2022
os.remove can raise PermissionError instead of IsADirectoryError, when the object to be removed is a directory (in particular on macOS). This reverts a change done in python#14262.
ronaldoussoren
added a commit
that referenced
this pull request
Nov 21, 2022
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 21, 2022
…99571) os.remove can raise PermissionError instead of IsADirectoryError, when the object to be removed is a directory (in particular on macOS). This reverts a change done in pythonGH-14262. (cherry picked from commit 1cae31d) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 21, 2022
…99571) os.remove can raise PermissionError instead of IsADirectoryError, when the object to be removed is a directory (in particular on macOS). This reverts a change done in pythonGH-14262. (cherry picked from commit 1cae31d) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
ronaldoussoren
added a commit
that referenced
this pull request
Nov 21, 2022
#99641) GH-95815: Document less specific error for os.remove (GH-99571) os.remove can raise PermissionError instead of IsADirectoryError, when the object to be removed is a directory (in particular on macOS). This reverts a change done in GH-14262. (cherry picked from commit 1cae31d) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com> Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
ronaldoussoren
added a commit
that referenced
this pull request
Nov 21, 2022
#99639) GH-95815: Document less specific error for os.remove (GH-99571) os.remove can raise PermissionError instead of IsADirectoryError, when the object to be removed is a directory (in particular on macOS). This reverts a change done in GH-14262. (cherry picked from commit 1cae31d) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 3151 introduced more specific
OSErrorsubclasses. This PR uses them in the documentation ofos` where appropriate.https://bugs.python.org/issue37346