gh-64376: Convert the time module to the Argument Clinic

[ZackerySpytz]

Co-Authored-By: Nikolaus Rath nikolaus@rath.org

https://bugs.python.org/issue20177

• Issue: Derby #8: Convert 28 sites to Argument Clinic across 2 files #64376

[ZackerySpytz]

As mentioned on the BPO issue, it doesn't seem practical to use the Argument Clinic instead of the gettmarg() utility function.

The time_clock_gettime() function was not converted -- there's an ifdef involving the PyArg_ParseTuple() call on AIX.

[jdemeyer]

Needs #14330

[jdemeyer]

Needs #14795 instead.

[encukou]

There are now (in current master) dedicated built-in functions to use for testing, which aren't very likely to gain Argument Clinic signatures. I suggest using _testcapi.meth_varargs, which returns (its module, tuple of arguments):

        import _testcapi
        meth = types.MethodType(_testcapi.meth_varargs, 32)
        self.assertEqual(meth(), (_testcapi, (32,)))

[jdemeyer]

There are now (in current master) dedicated built-in functions to use for testing, which aren't very likely to gain Argument Clinic signatures. I suggest using _testcapi.meth_varargs, which returns (its module, tuple of arguments):

This PR shouldn't change test_gdb.py at all. The only reason that it was changed in this PR was to fix a test failure because test_gdb.py was using gmtime().

[encukou]

It no longer changes test_gdb. My comment was about Lib/unittest/test/testmock/testhelpers.py.
Sorry for the confusion.

[serhiy-storchaka]

Maybe use a converter?

Suggested change

	seconds: object = NULL
	seconds as when: object(converter="object_to_time_t", type="time_t") = None

Or introduce a named converter?

Note also that you can use None as a default value for better signature.

[serhiy-storchaka]

Suggested change

	format: object = NULL
	format: object(c_default="NULL") = "%a %b %d %H:%M:%S %Y"

[serhiy-storchaka]

Why rename module?

[serhiy-storchaka]

It is a single sentence. Either write it in one line or make separate sentences.

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[taleinat]

Ping, @ZackerySpytz?

[erlend-aasland]

No response since 2020. In the three years since 2020, there has been a lot of changes to Modules/timemodule.c¹. I suggest to close this PR; if someone wants to pick this up, it will probably be easier to start from scratch, rather than rebasing this PR.

Footnotes

1. 569 insertions(+), 231 deletions(-) ↩