Skip to content

gh-117657: Remove remaining TSan suppressions #143499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 3 commits into from
Jan 7, 2026
Merged

gh-117657: Remove remaining TSan suppressions #143499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27e68c8
gh-117657: Remove remaining TSan suppressions
colesbury Jan 6, 2026
2e39075
Add comment that suppression file is empty
colesbury Jan 7, 2026
109492c
Merge branch 'main' into gh-117657-remove-suppressions
colesbury Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Tools/tsan/suppressions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# This file contains suppressions for the default (with GIL) build.
# reference: https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions
#
# Reference: https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions
#
# When adding a suppression, include a comment referencing a GitHub issue
# that describes how to reproduce the race and includes the relevant TSan
# output.

# https://gist.github.com/mpage/daaf32b39180c1989572957b943eb665
thread:pthread_create
# There are currently no active suppressions. This file is kept so tooling
# that expects it can still find it.
24 changes: 9 additions & 15 deletions Tools/tsan/suppressions_free_threading.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
# This file contains suppressions for the free-threaded build. It contains the
# suppressions for the default build and additional suppressions needed only in
# This file contains suppressions for the free-threaded build. It includes the
# default build suppressions plus any additional suppressions needed only in
# the free-threaded build.
#
# reference: https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions

Copy link
Member

@Yhg1s Yhg1s Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a "this page intentionally left blank" comment, to make it clear this really is meant to be empty but we don't want to delete it because tooling might be expect it to exist in 3.15 like it did in 3.14. (I assume that's why you aren't deleting it.)

## Free-threaded suppressions


# These entries are for warnings that trigger in a library function, as called
# by a CPython function.

# These warnings trigger directly in a CPython function.

race_top:_PyObject_TryGetInstanceAttribute
# Reference: https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions
#
# When adding a suppression, include a comment referencing a GitHub issue
# that describes how to reproduce the race and includes the relevant TSan
# output.

# https://gist.github.com/mpage/6962e8870606cfc960e159b407a0cb40
thread:pthread_create
# There are currently no active suppressions. This file is kept so tooling
# that expects it can still find it.
Loading