gh-143443: Try to fix test_ssl_in_multiple_threads #143510
Draft
+33
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkey-patch not thread-safe subTest. Ensure that waiting for all threads does not hang indefinitely.
Comment on lines
+3028
to
+3034
| with threading_helper.catch_threading_exception() as cm: | ||
| with threading_helper.start_threads(threads): | ||
| pass | ||
| if cm.exc_value is not None: | ||
| # Some threads can skip their test | ||
| if not isinstance(cm.exc_value, unittest.SkipTest): | ||
| raise cm.exc_value |
Member
There was a problem hiding this comment.
Let's use threading_helper.run_concurrently for this instead.
Member
Author
There was a problem hiding this comment.
Nice helper, but it is not applicable here. It runs the same function in multiple threads.
Member
There was a problem hiding this comment.
But isn't that what we want to do?
Member
Author
There was a problem hiding this comment.
Currently it runs several different tests concurrently multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monkey-patch not thread-safe subTest.
Ensure that waiting for all threads does not hang indefinitely.
test_ssl_in_multiple_threadsis flaky due towith self.subTestwith threads #143443