-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-143632: Disable PR_SET_VMA_ANON_NAME on musl libc #143730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
corona10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: configure was not regenerated locally since CPython
does not support autoreconf on macOS.
Would you like to run make regen-configure
It will run based on container.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks for pointing this out, sure I’m happy to run it. |
|
The configure script is still not updated. Please do so. And only request reviews when the CI is green again. |
|
I tried to regenerate |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
On Alpine Linux (musl libc), enabling
PR_SET_VMA_ANON_NAMEcan cause build failures due to redefinition ofstruct prctl_mm_map.musl libc redefines this struct in
sys/prctl.h, which conflicts withlinux/prctl.h. The configure check forPR_SET_VMA_ANON_NAMEis not realiable on musl and may pass onsome architectures but fail later during build.
This change disables the feature detection on musl to avoid the header conflict and keep the build behavior consistent.
Note:
configurewas not regenerated locally since CPythondoes not support autoreconf on macOS.
Fixes gh-143632.