Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38006: Avoid closure in weakref.WeakValueDictionary #15641

Merged
merged 2 commits into from
Sep 9, 2019
Merged

bpo-38006: Avoid closure in weakref.WeakValueDictionary #15641

merged 2 commits into from
Sep 9, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 2, 2019 •
edited by bedevere-bot
Loading

weakref.WeakValueDictionary defines a local remove() function used as
callback for weak references. This function was created with a
closure. Modify the implementation to avoid the closure.

https://bugs.python.org/issue38006

@vstinner
bpo-38006: Avoid closure in weakref.WeakValueDictionary
36af58a 
weakref.WeakValueDictionary defines a local remove() function used as
callback for weak references. This function was created with a
closure.  Modify the implementation to avoid the closure.
tiran
tiran approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactorization solves my segfault issue.

@vstinner vstinner merged commit a2af05a into python:master Sep 9, 2019
@vstinner vstinner deleted the weakref_closure branch September 9, 2019 14:56
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2019
@vstinner @miss-islington
bpo-38006: Avoid closure in weakref.WeakValueDictionary (pythonGH-15641)
3762eaa 
weakref.WeakValueDictionary defines a local remove() function used as
callback for weak references. This function was created with a
closure.  Modify the implementation to avoid the closure.
(cherry picked from commit a2af05a)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot
Copy link

GH-15787 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a2af05a0d3f0da06b8d432f52efa3ecf29038532 3.7

@bedevere-bot
Copy link

GH-15789 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Sep 9, 2019
@miss-islington @vstinner
bpo-38006: Avoid closure in weakref.WeakValueDictionary (GH-15641)
78d15fa 
weakref.WeakValueDictionary defines a local remove() function used as
callback for weak references. This function was created with a
closure.  Modify the implementation to avoid the closure.
(cherry picked from commit a2af05a)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
vstinner added a commit that referenced this pull request Sep 9, 2019
@vstinner
bpo-38006: Avoid closure in weakref.WeakValueDictionary (GH-15641) (G…
2366933 
…H-15789)

weakref.WeakValueDictionary defines a local remove() function used as
callback for weak references. This function was created with a
closure.  Modify the implementation to avoid the closure.

(cherry picked from commit a2af05a)
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@vstinner @websurfer5
bpo-38006: Avoid closure in weakref.WeakValueDictionary (pythonGH-15641)
81249d5 
weakref.WeakValueDictionary defines a local remove() function used as
callback for weak references. This function was created with a
closure.  Modify the implementation to avoid the closure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran approved these changes

Assignees

@vstinner vstinner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @miss-islington @bedevere-bot @tiran @the-knights-who-say-ni