Skip to content

bpo-39040: added whitespaced to linesep_splitter in email.policy #17590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

bpo-39040: added whitespaced to linesep_splitter in email.policy #17590

wants to merge 1 commit into from

Conversation

manfred-kaiser
Copy link

@manfred-kaiser manfred-kaiser commented Dec 13, 2019

I'm working on a mailfilter in python and used the method "get_filename" of the "EmailMessage" class.

In some cases a wrong filename was returned. The reason was, that the Content-Disposition Header had a line break and the following intention was interpreted as part of the filename.
After fixing this bug, I was able to get the right filename.

https://bugs.python.org/issue39040

I had to change "linesep_splitter" in "email.policy" to match the intention.

Old Value:
linesep_splitter = re.compile(r'\n|\r')

New Value:
linesep_splitter = re.compile(r'\n\s+|\r\s+')

https://bugs.python.org/issue39040

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@manfred-kaiser

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@manfred-kaiser manfred-kaiser changed the title issue39040 - added whitespaced to linesep_splitter in email.policy #39040 - added whitespaced to linesep_splitter in email.policy Dec 13, 2019
@manfred-kaiser manfred-kaiser changed the title #39040 - added whitespaced to linesep_splitter in email.policy added whitespaced to linesep_splitter in email.policy Dec 13, 2019
@manfred-kaiser manfred-kaiser changed the title added whitespaced to linesep_splitter in email.policy bpo-39040: added whitespaced to linesep_splitter in email.policy Dec 13, 2019
@bitdancer
Copy link
Member

As noted in the issue this fix is incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants