Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-16575: Disabled checks for union types being passed by value. #17960

Merged
merged 1 commit into from
Jan 12, 2020
Merged

bpo-16575: Disabled checks for union types being passed by value. #17960

merged 1 commit into from
Jan 12, 2020

Conversation

vsajip
Copy link
Member

@vsajip vsajip commented Jan 12, 2020 •
edited by bedevere-bot
Loading

Although the underlying libffi issue remains open, adding these checks have caused problems in third-party projects which are in widespread use. See the issue for examples.

The corresponding tests have also been skipped.

https://bugs.python.org/issue16575

@vsajip
bpo-16575: Disabled checks for union types being passed by value.
53dcc46 
Although the underlying libffi issue remains open, adding these
checks have caused problems in third-party projects which are in
widespread use. See the issue for examples.

The corresponding tests have also been skipped.
@vsajip vsajip added type-bug An unexpected behavior, bug, or error skip news labels Jan 12, 2020
@vsajip vsajip merged commit c12440c into python:master Jan 12, 2020
@vsajip vsajip deleted the fix-16575 branch January 12, 2020 08:54
@miss-islington
Copy link
Contributor

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2020
@vsajip @miss-islington
bpo-16575: Disabled checks for union types being passed by value. (py…
85b8bdb 
…thonGH-17960)

Although the underlying libffi issue remains open, adding these
checks have caused problems in third-party projects which are in
widespread use. See the issue for examples.

The corresponding tests have also been skipped.
(cherry picked from commit c12440c)

Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
@bedevere-bot
Copy link

GH-17964 is a backport of this pull request to the 3.8 branch.

vsajip pushed a commit that referenced this pull request Jan 12, 2020
@miss-islington @vsajip
bpo-16575: Disabled checks for union types being passed by value. (GH…
eb9ba2f 
…-17960) (GH-17964)

Although the underlying libffi issue remains open, adding these
checks have caused problems in third-party projects which are in
widespread use. See the issue for examples.

The corresponding tests have also been skipped.

(cherry picked from commit c12440c)
@miss-islington
Copy link
Contributor

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.7. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.7 label.

@miss-islington
Copy link
Contributor

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @vsajip, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c12440c371025bea9c3bfb94945f006c486c2c01 3.7

vsajip added a commit that referenced this pull request Jan 12, 2020
@vsajip
bpo-16575: Disabled checks for union types being passed by value. (GH…
d9132a4 
…-17960)

Although the underlying libffi issue remains open, adding these
checks have caused problems in third-party projects which are in
widespread use. See the issue for examples.

The corresponding tests have also been skipped.
(cherry picked from commit c12440c)
@bedevere-bot
Copy link

GH-17970 is a backport of this pull request to the 3.7 branch.

vsajip added a commit that referenced this pull request Jan 12, 2020
@vsajip
[3.7] bpo-16575: Disabled checks for union types being passed by valu…
9dbf5d3 
…e. (GH-17960) (GH-17970)

Although the underlying libffi issue remains open, adding these
checks have caused problems in third-party projects which are in
widespread use. See the issue for examples.

The corresponding tests have also been skipped.
(cherry picked from commit c12440c)
This was referenced Jan 14, 2020
Closed
Closed
@airelil airelil mentioned this pull request Jan 15, 2020
Open
@josephsl josephsl mentioned this pull request Jan 21, 2020
Closed
@blacklight blacklight mentioned this pull request Jan 21, 2020
Open
@mmacata mmacata mentioned this pull request Jan 28, 2020
Merged
@neteler neteler mentioned this pull request Jan 28, 2020
Closed
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@vsajip @shihai1991
bpo-16575: Disabled checks for union types being passed by value. (py…
3792b4b 
…thonGH-17960)

Although the underlying libffi issue remains open, adding these
checks have caused problems in third-party projects which are in
widespread use. See the issue for examples.

The corresponding tests have also been skipped.
@metzm metzm mentioned this pull request Feb 7, 2020
Merged
@mworion mworion mentioned this pull request Oct 12, 2020
Closed
@arigo arigo mannequin mentioned this pull request Apr 10, 2022
Open
@junkmd junkmd mentioned this pull request Feb 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vsajip vsajip

Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsajip @miss-islington @bedevere-bot @the-knights-who-say-ni