bpo-39323: Fix directory separator of imghdr cli output #17993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use os.sep to display path directories for better compatibility * Add tests for imghdr cli
corona10
reviewed
Jan 14, 2020
| @@ -148,7 +148,7 @@ def testall(list, recursive, toplevel): | |||
| import os | |||
| for filename in list: | |||
| if os.path.isdir(filename): | |||
| print(filename + '/:', end=' ') | |||
| print(filename + os.sep +':', end=' ') | |||
There was a problem hiding this comment.
I don't know this kind of code churn is proper,
But if this is needed, what about this?
print(f'{filename}{os.sep}:', end=' ')There was a problem hiding this comment.
As a personal opinion, I don't see much improvement here in changing. It's just concatenating two separate variables and there are no other strings also as part of string like a + " equals " + b to f"{a} equals {b}" .
eamanu
approved these changes
Jul 20, 2020
|
Note the imghdr modules is deprecated in 3.11 and set for removal in 3.13. See PEP 594 – Removing dead batteries from the standard library and #91217. @corona10 If you're happy to merge this, I suggest going ahead anyway, otherwise it could be closed. :) |
|
Thanks @hugovk , I am okay with closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.septo indicate directory separator in imghdr cli output.https://bugs.python.org/issue39323