Skip to content

bpo-1635741: Port _abc extension module to multiphase initialization(PEP 489) #18030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2020
Merged

bpo-1635741: Port _abc extension module to multiphase initialization(PEP 489) #18030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0a9589
Port _abc extension module to multiphase initialization(PEP 489)
shihai1991 Jan 16, 2020
ba41ab9
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 16, 2020
596ab3c
update news
shihai1991 Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2020-01-16-12-00-04.bpo-1635741.fuqoBG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Port _abc extension module to multiphase initialization (:pep:`489`).
27 changes: 18 additions & 9 deletions Modules/_abc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,26 +807,35 @@ static struct PyMethodDef module_functions[] = {
{NULL, NULL} /* sentinel */
};

static int
_abc_exec(PyObject *module)
{
if (PyType_Ready(&_abc_data_type) < 0) {
return -1;
}
_abc_data_type.tp_doc = abc_data_doc;
return 0;
}

static PyModuleDef_Slot _abc_slots[] = {
{Py_mod_exec, _abc_exec},
{0, NULL}
};

static struct PyModuleDef _abcmodule = {
PyModuleDef_HEAD_INIT,
"_abc",
_abc__doc__,
-1,
0,
module_functions,
NULL,
_abc_slots,
NULL,
NULL,
NULL
};


PyMODINIT_FUNC
PyInit__abc(void)
{
if (PyType_Ready(&_abc_data_type) < 0) {
return NULL;
}
_abc_data_type.tp_doc = abc_data_doc;

return PyModule_Create(&_abcmodule);
return PyModuleDef_Init(&_abcmodule);
}