Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35134: Migrate frameobject.h contents to cpython/frameobject.h #18052

Merged
merged 1 commit into from
Jan 20, 2020
Merged

bpo-35134: Migrate frameobject.h contents to cpython/frameobject.h #18052

merged 1 commit into from
Jan 20, 2020

Conversation

ncoghlan
Copy link
Contributor

@ncoghlan ncoghlan commented Jan 18, 2020 •
edited by bedevere-bot
Loading

The patch for PEP 558 (bpo-30744) adds a number of new frame-related
C APIs. This prepatory patch migrates frameobject.h to the modern layout
with multiple include files so the PEP reference implementation can clearly
separate the stable ABI additions from the full CPython C API additions.

https://bugs.python.org/issue35134

@ncoghlan ncoghlan requested a review from vstinner January 18, 2020 13:51
@ncoghlan ncoghlan mentioned this pull request Jan 18, 2020
Closed
27 tasks
vstinner
vstinner approved these changes Jan 19, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can use bpo-35134 in the commit title if you want.

@ncoghlan ncoghlan changed the title Migrate frameobject.h contents to cpython/frameobject.h bpo-35134: Migrate frameobject.h contents to cpython/frameobject.h Jan 20, 2020
@ncoghlan ncoghlan merged commit 1e420f8 into python:master Jan 20, 2020
@ncoghlan ncoghlan deleted the move-frameobject-header branch January 20, 2020 22:21
@ncoghlan
Copy link
Contributor Author

Thanks for the review!

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@ncoghlan @shihai1991
bpo-35134: Migrate frameobject.h contents to cpython/frameobject.h (p…
6f10493 
…ythonGH-18052)
@njsmith njsmith mentioned this pull request Apr 10, 2022
Closed
@vstinner vstinner mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncoghlan @vstinner @the-knights-who-say-ni @bedevere-bot