Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39573: Use Py_IS_TYPE to check for types #18809

Merged
merged 2 commits into from
Mar 6, 2020
Merged

bpo-39573: Use Py_IS_TYPE to check for types #18809

merged 2 commits into from
Mar 6, 2020

Conversation

petdance
Copy link
Contributor

@petdance petdance commented Mar 6, 2020 •
edited by bedevere-bot
Loading

This is an updated version of #18798. It replaces the last few places where we can use Py_IS_TYPE.

cc @vstinner

https://bugs.python.org/issue39573

@petdance petdance mentioned this pull request Mar 6, 2020
Closed
vstinner
vstinner approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner
Copy link
Member

vstinner commented Mar 6, 2020

I had to fix a conflict. Ping me if I forget to merge it.

@vstinner vstinner merged commit 5572870 into python:master Mar 6, 2020
@vstinner vstinner mentioned this pull request Mar 6, 2020
Closed
@petdance petdance deleted the bpo-39573-E branch March 7, 2020 04:02
@petdance petdance restored the bpo-39573-E branch March 7, 2020 04:02
@petdance petdance deleted the bpo-39573-E branch March 7, 2020 04:02
@vstinner vstinner mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petdance @vstinner @the-knights-who-say-ni @bedevere-bot