Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-1635741: Port math module to multiphase initialization #19243

Merged
merged 2 commits into from
Mar 31, 2020
Merged

bpo-1635741: Port math module to multiphase initialization #19243

merged 2 commits into from
Mar 31, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Mar 31, 2020 •
edited by bedevere-bot
Loading

vstinner
vstinner reviewed Mar 31, 2020
View reviewed changes
Modules/mathmodule.c Outdated Show resolved Hide resolved
shihai1991
shihai1991 approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@shihai1991 shihai1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shihai1991
Copy link
Member

https://discuss.python.org/t/vote-to-promote-dong-hee-na/3794
Good Job, Dong-hee Na 👍

@vstinner vstinner merged commit 5be8241 into python:master Mar 31, 2020
@corona10
Copy link
Member Author

@shihai1991 Thanks a lot :)

@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
@corona10 corona10 deleted the bpo-1635741-mathmodule branch February 15, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@shihai1991 shihai1991 shihai1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @shihai1991 @vstinner @the-knights-who-say-ni @bedevere-bot