Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] bpo-40275: Add loggingutils in test.support #19599

Closed
wants to merge 4 commits into from
Closed

[WIP] bpo-40275: Add loggingutils in test.support #19599

wants to merge 4 commits into from
+43 −37

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Apr 19, 2020 •
edited by bedevere-bot
Loading

@shihai1991 shihai1991 requested a review from vsajip as a code owner April 19, 2020 10:41
@shihai1991 shihai1991 changed the title bpo-40275: Add loggingutils in test.support [WIP] bpo-40275: Add loggingutils in test.support Apr 19, 2020
@shihai1991
fix testcases

Verified

This commit was signed with the committer’s verified signature.
JohnTitor Yuki Okushi
GPG key ID: B0986C85C0E2DAA1
Verified
Learn about vigilant mode
dc9741b
@tirkarthi
Copy link
Member

cc: @serhiy-storchaka . There is also similar work at #19601 .

@serhiy-storchaka
Copy link
Member

TestHandler is only used in test_logging. There is no reason to not define it there.

Also, removing import logging from test.support does not help while logging is imported in unittest. #19601 does all necessary to optimize import.

@shihai1991
Copy link
Member Author

TestHandler is only used in test_logging. There is no reason to not define it there.

Oh, thanks. I just left a same question in PR19601.

@shihai1991 shihai1991 closed this Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shihai1991 @tirkarthi @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot