Skip to content

bpo-40330: Fix utf-8 size check in ShareableList #19606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 3 commits into from
Apr 20, 2020
Merged

bpo-40330: Fix utf-8 size check in ShareableList #19606

miss-islington merged 3 commits into from
Apr 20, 2020

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Apr 19, 2020 •
edited by miss-islington
Loading

The item size must be checked after encoding to bytes, not before.

https://bugs.python.org/issue40330

Automerge-Triggered-By: @pitrou

@pitrou
bpo-40330: Fix utf-8 size check in ShareableList
65e2b7c 
The item size must be checked after encoding to bytes, not before.
@pitrou pitrou requested a review from tiran as a code owner April 19, 2020 15:27
@pitrou pitrou requested review from aeros and removed request for tiran April 19, 2020 16:20
aeros
aeros approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, I just have a minor suggestion for the tests.

@miss-islington
Copy link
Contributor

miss-islington commented Apr 20, 2020

@pitrou: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit eba9f61 into python:master Apr 20, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Apr 20, 2020

Thanks @pitrou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Apr 20, 2020

Sorry, @pitrou, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker eba9f6155df59c9beed97fb5764c9f01dd941af0 3.8

@miss-islington miss-islington self-assigned this Apr 20, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Apr 20, 2020

Sorry @pitrou, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker eba9f6155df59c9beed97fb5764c9f01dd941af0 3.7

@bedevere-bot
Copy link

bedevere-bot commented Apr 20, 2020

GH-19625 is a backport of this pull request to the 3.8 branch.

pitrou added a commit to pitrou/cpython that referenced this pull request Apr 20, 2020
@pitrou
[3.8] bpo-40330: Fix utf-8 size check in ShareableList (pythonGH-19606)
6bccb86 
The item size must be checked after encoding to bytes, not before.

Automerge-Triggered-By: @pitrou.
(cherry picked from commit eba9f61)

Co-authored-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou deleted the bpo40330-utf8-size-validation branch April 20, 2020 19:00
pitrou added a commit that referenced this pull request Apr 20, 2020
@pitrou
[3.8] bpo-40330: Fix utf-8 size check in ShareableList (GH-19606) (GH…
887ff8e 
…-19625)

The item size must be checked after encoding to bytes, not before.

Automerge-Triggered-By: @pitrou.
(cherry picked from commit eba9f61)

Co-authored-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aeros aeros aeros approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@miss-islington miss-islington

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pitrou @miss-islington @bedevere-bot @aeros @the-knights-who-say-ni