Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Add missing space in urllib.request.rst #19860

Merged
merged 1 commit into from
May 23, 2020

Conversation

imomaliev
Copy link
Contributor

@imomaliev imomaliev commented May 2, 2020

This is just a typo fix, should I still provide news file?

Automerge-Triggered-By: @csabella

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@imomaliev

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @imomaliev thanks for the PR, a NEWS entry is not needed for documentation improvement.

Please sign the CLA as @the-knights-who-say-ni said, you will need it if you want to contribute other changes to Python.

@imomaliev
Copy link
Contributor Author

@remilapeyre Hi, thanks! I should have done all of this before creating PR)) I've sent my signed CLA. I had to sign it twice because I have made a mistake. The latest one should be correct.

Copy link
Contributor

@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the contribution!

@miss-islington miss-islington merged commit 8022eb4 into python:master May 23, 2020
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
This is just a typo fix, should I still provide news file?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants