Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39573: Use Py_IS_TYPE to check for types #19882

Merged
merged 1 commit into from
May 4, 2020
Merged

bpo-39573: Use Py_IS_TYPE to check for types #19882

merged 1 commit into from
May 4, 2020

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented May 3, 2020 •
edited by bedevere-bot
Loading

@shihai1991
Copy link
Member Author

rough idea: Can we create a review robot to remind committer use the common macros or inline functions?

@corona10 corona10 changed the title WIP: Use Py_IS_TYPE to check for types bpo-39573: [WIP] Use Py_IS_TYPE to check for types May 3, 2020
@corona10
Copy link
Member

corona10 commented May 3, 2020 •
edited by bedevere-bot
Loading

This PR can be part of bpo-39573 which actually introducing and applying Py_IS_TYPE for the first time.

@corona10 corona10 requested a review from vstinner May 3, 2020 12:42
corona10
corona10 approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We often do not accept the PR which can be just refactoring work with insignificant reason.
However, this PR is handling module what #18521 did not.
So I approve of this change as the exception.

But we need to hear @vstinner 's opinion :)

Thanks for the work

@shihai1991
Copy link
Member Author

This PR can be part of bpo-39573 which actually introducing and applying Py_IS_TYPE for the first time.

yeap. You are the author ;)

@shihai1991 shihai1991 changed the title bpo-39573: [WIP] Use Py_IS_TYPE to check for types bpo-39573: Use Py_IS_TYPE to check for types May 3, 2020
@corona10
Copy link
Member

corona10 commented May 3, 2020

@shihai1991
But I approve the current change, so if the PR is updated for the more module.
Please request a review again.

@shihai1991
Copy link
Member Author

@shihai1991
But I approve the current change, so if the PR is updated for the more module.
Please request a review again.

Thanks, I have checked all modules, there have no more should be ported.

@corona10 corona10 merged commit 5e8ffe1 into python:master May 4, 2020
@vstinner vstinner mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shihai1991 @corona10 @the-knights-who-say-ni @bedevere-bot