bpo-40661: Fix segfaults when parsing invalid input #20159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bpo-40661. (In fact this just is the patch from @pablogsal from that issue.) Note that for an extreme benchmark (xxl.py) this caused a 40% slowdown on my Mac. However for an "average" benchmark (stdlib) there was no significant difference.
gvanrossum
changed the title
|
|
lysnikolaou
reviewed
May 17, 2020
Comment on lines
+684
to
+688
| self.print("if (p->error_indicator == 1 || PyErr_Occurred()) {") | ||
| with self.indent(): | ||
| self.print("p->error_indicator = 1;") | ||
| self.print("return NULL;") | ||
| self.print("}") |
There was a problem hiding this comment.
I'd actually move this within the scope block of the alternative (after the with self.indent() below).
|
Lysandros, can you take over responsibility for this PR? I'm just out of
energy for this.
|
|
Yes, of course! Should we close it and open a new one, since I can't push to a branch of the upstream repo? |
|
Sure.
|
|
Ok, closing. |
To follow up: I believe this may have been an exaggerated outcome because I built with debug flags on (and had forgotten about it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bpo-40661. (In fact this just is the patch from @pablogsal from
that issue.)
Note that for an extreme benchmark (xxl.py) this caused a 40% slowdown
on my Mac. However for an "average" benchmark (stdlib) there was no
significant difference.
https://bugs.python.org/issue40661