bpo-37999: Fix outdated __int__ and nb_int references in comments #20449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
approved these changes
May 27, 2020
| @@ -144,13 +143,15 @@ distinguished from a number. Use :c:func:`PyErr_Occurred` to disambiguate. | |||
| .. deprecated:: 3.8 | |||
| Using :meth:`__int__` is deprecated. | |||
|
|
|||
| .. versionchanged:: 3.10 | |||
| This function will no longer use :meth:`__int__`. | |||
There was a problem hiding this comment.
We usually also remove corresponding deprecated directives when the deprecated feature has been removed. So I suggest to remove deprecated few lines above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some out-of-date comments in
longobject.c.EDIT: updated to also remove outdated mentions of
__int__from the C-API documentation.See also #15636.
https://bugs.python.org/issue37999