-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
bpo-40275: Add warnings_helper submodule in test.support #20797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vstinner Hi, victor. Pls take a look if you have free times. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In support/init.py, "import warnings" is only used by _MemoryWatchdog. Can you please move the import inside _MemoryWatchdog.start()? That's the whole purpose of https://bugs.python.org/issue40275 : remove imports.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
make sense, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
thanks, victor. |
move the following functions, classes to warnings_helper:
https://bugs.python.org/issue40275