Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-1635741: Port nis module to multiphase initialization. #20808

Closed
wants to merge 1 commit into from
Closed

bpo-1635741: Port nis module to multiphase initialization. #20808

wants to merge 1 commit into from

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Jun 11, 2020 •
edited by bedevere-bot
Loading

@corona10 corona10 requested a review from vstinner June 11, 2020 14:27
vstinner
vstinner requested changes Jun 11, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to start with a PR which adds a module state to get NisError.

Otherwise, it's unclear who owns this exception.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@corona10
Copy link
Member Author

I would prefer to start with a PR which adds a module state to get NisError.

Good! I will submit the PR for that

@corona10 corona10 closed this Jun 11, 2020
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
@corona10 corona10 deleted the bpo-1635741-nis branch February 15, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner requested changes

Assignees
No one assigned
Labels
awaiting changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corona10 @bedevere-bot @vstinner @the-knights-who-say-ni