bpo-40995: reprlib.Repr attributes can be overriden in __init__() #20925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,7 +17,9 @@ debugger and may be useful in other contexts as well. | |||
| This module provides a class, an instance, and a function: | |||
|
|
|||
|
|
|||
| .. class:: Repr() | |||
| .. class:: Repr(self, *, maxlevel=6, maxtuple=6, maxlist=6, maxarray=5, \ | |||
There was a problem hiding this comment.
self should not be included here.
| :class:`Repr` instances provide several attributes which can be used to provide | ||
| size limits for the representations of different object types, and methods | ||
| which format specific object types. | ||
| .. class:: Repr(self, *, maxlevel=6, maxtuple=6, maxlist=6, maxarray=5, \ |
There was a problem hiding this comment.
self should not be included here.
Comment on lines
+21
to
+22
| maxdict=4, maxset=6, maxfrozenset=6, maxdeque=6, maxstring=30, \ | ||
| maxlong=40, maxother=30) |
There was a problem hiding this comment.
Please align these lines with the (.
Comment on lines
+77
to
+78
| maxdict=4, maxset=6, maxfrozenset=6, maxdeque=6, maxstring=30, \ | ||
| maxlong=40, maxother=30) |
There was a problem hiding this comment.
Please align these lines with the (.
| r = Repr() | ||
| self.assertEqual(r.repr(a), "'aaaaaaaaaaaa...aaaaaaaaaaaaa'") | ||
| r = Repr(maxstring=10) | ||
| self.assertEqual(r.repr(a), "'aa...aaa'") |
There was a problem hiding this comment.
I think more tests need to be provided.
|
|
||
| :class:`Repr` instances provide several attributes which can be used to provide |
There was a problem hiding this comment.
Please limit lines to 80 characters in reST files (https://devguide.python.org/documenting/#use-of-whitespace).
|
Looks like some version of this was actually merged, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40995