bpo-40968: Send http/1.1 ALPN extension #20959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
added
type-bug
|
sethmlarson
reviewed
Jun 18, 2020
| @@ -1377,6 +1377,8 @@ def __init__(self, host, port=None, key_file=None, cert_file=None, | |||
| self.cert_file = cert_file | |||
| if context is None: | |||
| context = ssl._create_default_https_context() | |||
| # send ALPN extension to indicate HTTP/1.1 protocol | |||
There was a problem hiding this comment.
Are this comment and the functionality out of sync here since http_vsn_str can be HTTP/1.0, etc? http/1.1, http/1.0, and http/0.9 are all valid ALPN protocol IDs but the comment and changelogs only mention 1.1. This might be fine anyways but something I noticed.
There was a problem hiding this comment.
I'm now checking _http_vsn and only send the ALPN extension when the version is 11 (HTTP/1.1).
Signed-off-by: Christian Heimes <christian@python.org>
tiran
force-pushed
the
bpo-40968-alpn
branch
from
320141f to
977ec2a
Compare
tiran
added
type-feature
|
@tiran: Please replace |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Signed-off-by: Christian Heimes <christian@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue40968