Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "stale" GitHub Action #21247

Merged
merged 5 commits into from
Dec 15, 2020
Merged

Adding "stale" GitHub Action #21247

merged 5 commits into from
Dec 15, 2020

Conversation

Mariatta
Copy link
Member

@Mariatta Mariatta commented Jun 30, 2020

Added the "stale" GitHub action to the CPython repo.
PR's older than 30 days will be labeld as stale using the "stale-pr" label.
If needed, it can be configured to more than 30 days.

I've added bedevere-bot's GitHub token to the repo's secret settings as BEDEVERE_GH_TOKEN

https://github.com/actions/stale

Closes python/core-workflow#372

Added the "stale" GitHub action to the CPython repo.
PR's older than 30 days will be labeld as stale using the "stale-pr" label.
If needed, it can be configured to more than 30 days.

I've added bedevere-bot's GitHub token to the repo's secret settings as ``BEDEVERE_GH_TOKEN``

Closes python/core-workflow#372
.github/workflows/stale.yml Outdated Show resolved Hide resolved
.github/workflows/stale.yml Outdated Show resolved Hide resolved
.github/workflows/stale.yml Outdated Show resolved Hide resolved
stale-pr-message: 'This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days'
stale-pr-label: 'stale-pr'
days-before-stale: 30
days-before-close: 5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we prepared to close out stale PRs? I think this would require a much wider discussion as that's a change in development approach.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a prior discussion in python/core-workflow#93 but we have never reached decision. I can ask in Discourse.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Mariatta and others added 3 commits July 2, 2020 12:39
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Brett Cannon <brett@python.org>
@Mariatta
Copy link
Member Author

Mariatta commented Jul 2, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from brettcannon July 2, 2020 19:56
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the structure of the PR while the discussion of whether this should gets merged happens.

@Mariatta
Copy link
Member Author

I've set the days-before-close to -1 so it doesn't close the PR, but stale label still gets applied.

@Mariatta Mariatta closed this Dec 15, 2020
@Mariatta Mariatta reopened this Dec 15, 2020
@Mariatta
Copy link
Member Author

I don't know why azure pipelines CI is failing 🙃 and I couldn't figure out how to restart it.

@Mariatta Mariatta merged commit 9cc8fa6 into master Dec 15, 2020
@Mariatta Mariatta deleted the Mariatta-patch-1 branch December 15, 2020 19:58
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Adding "stale" GitHub Action

Added the "stale" GitHub action to the CPython repo.
PR's older than 30 days will be labeled as stale using the "stale-pr" label.

Closes python/core-workflow#372

Co-authored-by: Brett Cannon <brett@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use "stale" GitHub actions to mark PRs as stale
4 participants