Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-1635741: port winapi to multi-stage init #21371

Merged
merged 9 commits into from
Aug 13, 2020
Merged

bpo-1635741: port winapi to multi-stage init #21371

merged 9 commits into from
Aug 13, 2020

Conversation

koubaa
Copy link
Contributor

@koubaa koubaa commented Jul 7, 2020 •
edited by bedevere-bot
Loading

@koubaa koubaa changed the title port winapi to multi-stage init bpo-1635741: port winapi to multi-stage init Jul 7, 2020
vstinner
vstinner reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @corona10 @shihai1991

vstinner
vstinner reviewed Jul 7, 2020
View reviewed changes
shihai1991
shihai1991 reviewed Jul 8, 2020
View reviewed changes
vstinner
vstinner reviewed Jul 8, 2020
View reviewed changes
vstinner
vstinner reviewed Jul 9, 2020
View reviewed changes
vstinner
vstinner reviewed Jul 9, 2020
View reviewed changes
@vstinner
Copy link
Member

vstinner commented Jul 9, 2020

continuous-integration/travis-ci Expected — Waiting for status to be reported
Required

Stupid CI. https://travis-ci.org/github/python/cpython/builds/706422141 ran and completed. But the status was not reported back to GitHub :-(

I restarted the build to try to work around the issue :-/

@vstinner
Copy link
Member

vstinner commented Jul 9, 2020

I still see " continuous-integration/travis-ci Expected — Waiting for status to be reported ". Hum, I close/reopen the issue to force to re-run all CIs :-(

@vstinner vstinner closed this Jul 9, 2020
@vstinner vstinner reopened this Jul 9, 2020
@vstinner
Copy link
Member

vstinner commented Jul 9, 2020

Right now, it's still " continuous-integration/travis-ci Expected — Waiting for status to be reported ". Silly CIs :-(

@koubaa
Copy link
Contributor Author

koubaa commented Aug 9, 2020

@vstinner can this be merged?

@vstinner
Copy link
Member

@corona10 @shihai1991: Would you mind to review this PR?

@shihai1991
Copy link
Member

shihai1991 commented Aug 10, 2020 •
edited
Loading

Hm, this ci gate skipped again, maybe we can fix it.

shihai1991
shihai1991 approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@shihai1991 shihai1991 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have no other comment in here.

@vstinner
Copy link
Member

Hm, this ci gate skipped again, maybe we can fix it.

See #21806

@koubaa koubaa closed this Aug 13, 2020
@koubaa koubaa reopened this Aug 13, 2020
@koubaa koubaa force-pushed the bpo-1635741-winapi branch from fce44d9 to 42352a4 Compare August 13, 2020 12:30
@koubaa
Copy link
Contributor Author

koubaa commented Aug 13, 2020

I just rebased it to reset the CI

@vstinner vstinner merged commit e087f7c into python:master Aug 13, 2020
@vstinner
Copy link
Member

Thanks @koubaa, I merged your PR. Thanks @shihai1991 for the review.

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@koubaa @shihai1991
bpo-1635741: Port _winapi ext to multi-stage init (pythonGH-21371)
1626edd
@koubaa koubaa deleted the bpo-1635741-winapi branch August 28, 2020 00:21
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@koubaa
bpo-1635741: Port _winapi ext to multi-stage init (pythonGH-21371)
b89d2cd
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@shihai1991 shihai1991 shihai1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@koubaa @vstinner @shihai1991 @the-knights-who-say-ni @bedevere-bot