bpo-1635741: port blake2 module to multi-phase init #21856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koubaa
force-pushed
the
bpo-1635741-blake2
branch
from
d282ca9 to
abb51fe
Compare
|
@vstinner @shihai1991 This is ready for review |
vstinner
reviewed
Aug 29, 2020
vstinner
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
LGTM, with a minor suggestion on the NEWS entry (please update it).
But right now, I cannot merge the PR: https://mail.python.org/archives/list/python-dev@python.org/thread/KMXK6BQWQZRR2TGVRLECMR7CUVIVTUMQ/
Please ping me when the workflow will be repaired, so I will merge your PR.
Misc/NEWS.d/next/Core and Builtins/2020-08-13-07-18-05.bpo-1635741.FC13e7.rst
Outdated
Show resolved
Hide resolved
|
@vstinner looks like the doc issue is fixed in the CI. |
|
Merged, thanks @koubaa. |
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
Port the _blake2 extension module to the multi-phase initialization API (PEP 489).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue1635741