-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-26053: Fix args echoed by pdb run command #22033
Conversation
@birkenfeld are you able to review this? |
Sorry, not at the moment. |
Misc/NEWS.d/next/Library/2020-09-01-10-12-13.bpo-26053.hXikw_.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Since I've not worked on pdb before, I'm still considering whether this should be backported.
This looks like a real bug fix and I am fine with backporting to 3.9 and 3.8. |
Shall we merge this? |
@gvanrossum: Please replace |
Does it need a backport? |
The bug is in 3.9 and 3.9 as well. |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Following up here: #25139 @bedevere-bot, you make a good point but you're coming on a bit strong. |
|
|
|
|
|
|
|
(cherry picked from commit 652bfde)
* bpo-26053: Fix args echoed by pdb run command (pythonGH-22033) (cherry picked from commit 652bfde) * bpo-26053: Fix test_pdb.test_issue26053() (pythonGH-25139) (cherry picked from commit bd4ab8e) (cherry picked from commit 7ad56e2) Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
https://bugs.python.org/issue26053