gh-85934: Use getattr_static when adding mock spec

Lib/test/test_unittest/testmock/testmock.py

@@ -38,6 +38,17 @@ def cmeth(cls, a, b, c, d=None): pass
  def smeth(a, b, c, d=None): pass
 
 
+class SomethingElse(object):
+ def __init__(self):
+ self._instance = None
+
+ @property
+ def instance(self):
+ if not self._instance:
+ self._instance = 'object'
+ return self._instance
+
+
 class Typos():
  autospect = None
  auto_spec = None
@@ -2293,6 +2304,12 @@ class Foo():
  f'{__name__}.Typos', autospect=True, set_spec=True, auto_spec=True):
  pass
 
+ def test_property_not_called_with_spec_mock(self):
+ obj = SomethingElse()
+ self.assertIsNone(obj._instance, msg='before mock')
+ mock = Mock(spec=obj)
+ self.assertIsNone(obj._instance, msg='after mock')
+ self.assertEqual('object', obj.instance)
 
 if __name__ == '__main__':
  unittest.main()

Lib/unittest/mock.py

@@ -526,7 +526,7 @@ def _mock_add_spec(self, spec, spec_set, _spec_as_instance=False,
  spec_list = dir(spec)
 
  for attr in spec_list:
- if iscoroutinefunction(getattr(spec, attr, None)):
+ if iscoroutinefunction(inspect.getattr_static(spec, attr, None)):
  _spec_asyncs.append(attr)
 
  spec = spec_list

Misc/NEWS.d/next/Library/2020-09-16-16-53-06.bpo-41768.8_fWkC.rst

@@ -0,0 +1 @@
+unittest.mock speccing no longer calls class properties