Skip to content

[3.8] bpo-41817: use new StrEnum to ensure all members are strings (GH-22348) #22366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2020
Merged

[3.8] bpo-41817: use new StrEnum to ensure all members are strings (GH-22348) #22366

merged 2 commits into from
Sep 22, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 22, 2020 •
edited by bedevere-bot
Loading

  • use new StrEnum to ensure all members are strings
    (cherry picked from commit ea0711a)

Co-authored-by: Ethan Furman ethan@stoneleaf.us

https://bugs.python.org/issue41817

@ethanfurman @miss-islington
bpo-41817: use new StrEnum to ensure all members are strings (pythonG…
34dc7b0 
…H-22348)

* use new StrEnum to ensure all members are strings
(cherry picked from commit ea0711a)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@bedevere-bot bedevere-bot mentioned this pull request Sep 22, 2020
Merged
@ethanfurman
fix EventType bases
0c13bb3 
`StrEnum` does not exist in 3.8, so use original `(str, enum.Enum)` bases.
@miss-islington
Copy link
Contributor Author

@ethanfurman: Status check is done, and it's a failure ❌ .

@miss-islington miss-islington merged commit 6d372ef into python:3.8 Sep 22, 2020
@miss-islington miss-islington deleted the backport-ea0711a-3.8 branch September 22, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot @ethanfurman