-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
Minor test fixes for zlib and gzip #22408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The unconsumed tail has a possibility to be empty, even if the end of compression is not reached
|
@rhpvorderman, thanks for this PR! The reasoning and changes suggested look good to me, but I'm not an expert on this. I've asked @Yhg1s, listed on the experts index as the expert on zlib, to review this. You're welcome to ping me in a few weeks if nobody else has reviewed this PR. |
|
@taleinat, No reviews so far. Not that these issues are very pressing. |
|
Ping, @Yhg1s? |
|
According to the devguide, this does not qualify for skip issue. IMO, this warrants an issue, despite being fairly trivial. |
|
No response since 2020. Marking as pending close. |
|
I will close it myself then. It is not of paramount importance as it is technically not broken. |
This is very minor so I did not create an issue on bugs.python.org.
I am working on a gzip-compatible library and used the tests from cpython to ensure that it was indeed compatible. I found these minor oversights when testing the library.
I also found test cases testing a Wbits of 32+15. Wbits sizes over 31 are undocumented in both the python and zlib documentation. Can anyone explain to me what these test cases are for, and why it is a hard requirement that these undocumented assumptions may never be broken by future python releases?I found it in the docs. It autodetects gzip or zlib style compression. That is quite a neat feature!