Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41861: Convert _sqlite3 RowType and StatementType to heap types #22444

Merged
merged 3 commits into from
Oct 1, 2020
Merged

bpo-41861: Convert _sqlite3 RowType and StatementType to heap types #22444

merged 3 commits into from
Oct 1, 2020

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Sep 28, 2020 •
edited by bedevere-bot
Loading

Part 3 of bpo-41861, @vstinner

Tested for ref. leaks with ./python.exe -m test -F -r -j1 -R 3:10 test_sqlite

https://bugs.python.org/issue41861

vstinner
vstinner approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you remove Py_TPFLAGS_HEAPTYPE.

@erlend-aasland
Copy link
Contributor Author

LGTM if you remove Py_TPFLAGS_HEAPTYPE.

See 6d22771

vstinner
vstinner approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@erlend-aasland
Copy link
Contributor Author

@vstinner Any idea why the macOS tests are failing? I'm unable to see the details (perhaps due to a recent change in the CI?). I'm tempted to just re-run the checks.

@vstinner
Copy link
Member

vstinner commented Oct 1, 2020

@vstinner Any idea why the macOS tests are failing? I'm unable to see the details (perhaps due to a recent change in the CI?). I'm tempted to just re-run the checks.

I don't see any logs. It looks like a bug on the GitHub Action. I don't know how to debug such issue.

These checks are not mandatory, you can safely ignore it.

@vstinner vstinner merged commit 9031bd4 into python:master Oct 1, 2020
@vstinner
Copy link
Member

vstinner commented Oct 1, 2020

Merged, thanks. Next? :-)

@erlend-aasland
Copy link
Contributor Author

Merged, thanks. Next? :-)

Thanks, coming right up! :)

@erlend-aasland erlend-aasland deleted the fix-bpo-41861/row-and-stmt branch October 1, 2020 13:25
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
bpo-41861: Convert _sqlite3 RowType and StatementType to heap types (p…
b5c008f 
…ythonGH-22444)
@erlend-aasland erlend-aasland mentioned this pull request Aug 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @vstinner @the-knights-who-say-ni @bedevere-bot