Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42018: winreg SetValue(Ex) should mention integer as an acceptable value #22671

Closed
wants to merge 2 commits into from

Conversation

kainjow
Copy link

@kainjow kainjow commented Oct 12, 2020

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@kainjow

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 12, 2020
Doc/library/winreg.rst Outdated Show resolved Hide resolved
@@ -473,7 +473,7 @@ This module offers the following functions:
*type* is an integer that specifies the type of the data. See
:ref:`Value Types <value-types>` for the available types.

*value* is a string that specifies the new value.
*value* is a string or integer that specifies the new value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be not only a string or integer. Acceptable types depend on the type argument.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically None, str, int, list (of str) or implements the buffer protocol.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it is better to document what types are acceptable for specific value of the type argument in the corresponding section value-types.

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 17, 2020
@github-actions
Copy link

Closing this stale PR because the CLA is still not signed.

@github-actions github-actions bot closed this Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants