Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38250: minor Flag refactor #22734

Closed
wants to merge 2 commits into from
Closed

bpo-38250: minor Flag refactor #22734

wants to merge 2 commits into from

Conversation

belm0
Copy link
Contributor

@belm0 belm0 commented Oct 17, 2020 •
edited
Loading

Extracted some minor refactoring from a larger work in progress:

  • clarify used return values of _decompose() calls
  • __invert__(): use in-place OR operator, remove unneeded cast

skip news

https://bugs.python.org/issue38250

auvipy
auvipy suggested changes Oct 17, 2020
View reviewed changes
Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont this need some test adjustment?

@belm0
Copy link
Contributor Author

belm0 commented Oct 17, 2020

dont this need some test adjustment?

no, since there is no change in functionality

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 24, 2020
@ethanfurman
Copy link
Member

@belm0 this PR is no longer valid as Flag has been redesigned (using much, if not all, of your input). I would appreciate your feedback on GH-24215.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy requested changes

@ethanfurman ethanfurman Awaiting requested review from ethanfurman

Assignees
No one assigned
Labels
awaiting core review stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@belm0 @ethanfurman @auvipy @the-knights-who-say-ni @bedevere-bot