bpo-1635741: Fix NULL ptr deref in multiprocessing #22880

tiran · 2020-10-22T08:09:05Z

Commit 1d541c2 introduced a NULL
pointer dereference in error path.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue1635741

Automerge-Triggered-By: GH:encukou

Commit 1d541c2 introduced a NULL pointer dereference in error path. Signed-off-by: Christian Heimes <christian@python.org>

bedevere-bot · 2020-10-22T10:50:06Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Clang 3.x has failed when building commit dde91b1.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/3/builds/214) and take a look at the build logs.
Check if the failure is related to this commit (dde91b1) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/3/builds/214

Failed tests:

test_lib2to3

Summary of the results of the build (if available):

==

Click to see traceback logs

remote: Enumerating objects: 9, done.        
remote: Counting objects:  11% (1/9)        
remote: Counting objects:  22% (2/9)        
remote: Counting objects:  33% (3/9)        
remote: Counting objects:  44% (4/9)        
remote: Counting objects:  55% (5/9)        
remote: Counting objects:  66% (6/9)        
remote: Counting objects:  77% (7/9)        
remote: Counting objects:  88% (8/9)        
remote: Counting objects: 100% (9/9)        
remote: Counting objects: 100% (9/9), done.        
remote: Compressing objects:  33% (1/3)        
remote: Compressing objects:  66% (2/3)        
remote: Compressing objects: 100% (3/3)        
remote: Compressing objects: 100% (3/3), done.        
remote: Total 5 (delta 4), reused 2 (delta 2), pack-reused 0        
From https://github.com/python/cpython
 * branch                  master     -> FETCH_HEAD
Reset branch 'master'

Python/pytime.c:154:10: warning: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-int-float-conversion]
    if (!_Py_InIntegralTypeRange(time_t, intpart)) {
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:228:82: note: expanded from macro '_Py_InIntegralTypeRange'
#define _Py_InIntegralTypeRange(type, v) (_Py_IntegralTypeMin(type) <= v && v <= _Py_IntegralTypeMax(type))
                                                                              ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:221:124: note: expanded from macro '_Py_IntegralTypeMax'
#define _Py_IntegralTypeMax(type) ((_Py_IntegralTypeSigned(type)) ? (((((type)1 << (sizeof(type)*CHAR_BIT - 2)) - 1) << 1) + 1) : ~(type)0)
                                                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Python/pytime.c:207:14: warning: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-int-float-conversion]
        if (!_Py_InIntegralTypeRange(time_t, intpart)) {
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:228:82: note: expanded from macro '_Py_InIntegralTypeRange'
#define _Py_InIntegralTypeRange(type, v) (_Py_IntegralTypeMin(type) <= v && v <= _Py_IntegralTypeMax(type))
                                                                              ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:221:124: note: expanded from macro '_Py_IntegralTypeMax'
#define _Py_IntegralTypeMax(type) ((_Py_IntegralTypeSigned(type)) ? (((((type)1 << (sizeof(type)*CHAR_BIT - 2)) - 1) << 1) + 1) : ~(type)0)
                                                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
Python/pytime.c:392:10: warning: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-int-float-conversion]
    if (!_Py_InIntegralTypeRange(_PyTime_t, d)) {
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:228:82: note: expanded from macro '_Py_InIntegralTypeRange'
#define _Py_InIntegralTypeRange(type, v) (_Py_IntegralTypeMin(type) <= v && v <= _Py_IntegralTypeMax(type))
                                                                              ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~
./Include/pymath.h:221:124: note: expanded from macro '_Py_IntegralTypeMax'
#define _Py_IntegralTypeMax(type) ((_Py_IntegralTypeSigned(type)) ? (((((type)1 << (sizeof(type)*CHAR_BIT - 2)) - 1) << 1) + 1) : ~(type)0)
                                                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
3 warnings generated.
./Modules/timemodule.c:116:13: warning: code will never be executed [-Wunreachable-code]
            PyErr_SetString(PyExc_OverflowError,
            ^~~~~~~~~~~~~~~
./Modules/_threadmodule.c:1587:19: warning: implicit conversion from '_PyTime_t' (aka 'long') to 'double' changes value from 9223372036854775 to 9223372036854776 [-Wimplicit-int-float-conversion]
    timeout_max = (_PyTime_t)PY_TIMEOUT_MAX * 1e-6;
                  ^~~~~~~~~~~~~~~~~~~~~~~~~ ~
1 warning generated.
1 warning generated.

test_ossaudiodev skipped -- [Errno 2] No such file or directory: '/dev/dsp'
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_readline skipped -- No module named 'readline'
test_ttk_guionly skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_winconsoleio skipped -- test only relevant on win32
test_tix skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_devpoll skipped -- test works only on Solaris OS family
test_winreg skipped -- No module named 'winreg'
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... ok
test_kqueue (__main__.SelectEINTRTest) ... skipped 'need select.kqueue'
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 6.386s

OK (skipped=2)
test_startfile skipped -- object <module 'os' from '/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/os.py'> has no attribute 'startfile'
test_msilib skipped -- No module named '_msi'
test_ioctl skipped -- Unable to open /dev/tty
test_winsound skipped -- No module named 'winsound'
Fatal Python error: Segmentation fault

Current thread 0x000003ff99078b20 (most recent call first):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/btm_matcher.py", line 125 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/refactor.py", line 414 in refactor_tree
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/refactor.py", line 371 in refactor_string
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/refactor.py", line 339 in refactor_file
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/tests/test_all_fixers.py", line 24 in test_all_project_files
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/case.py", line 549 in _callTestMethod
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/case.py", line 592 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/case.py", line 652 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/runner.py", line 176 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/support/__init__.py", line 959 in _run_suite
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/support/__init__.py", line 1082 in run_unittest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 211 in _test_module
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 236 in _runtest_inner2
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 272 in _runtest_inner
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 142 in _runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 195 in runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest_mp.py", line 81 in run_tests_worker
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/main.py", line 659 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/main.py", line 639 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/main.py", line 717 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/regrtest.py", line 43 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/regrtest.py", line 47 in <module>
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/runpy.py", line 87 in _run_code
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/runpy.py", line 197 in _run_module_as_main
test_tk skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_kqueue skipped -- test works only on BSD
test_nis skipped -- No module named 'nis'
/tmp/tmp3go63d5c/parse.c:136:19: warning: code will never be executed [-Wunreachable-code]
        p->mark = _mark;
                  ^~~~~
1 warning generated.
Fatal Python error: Segmentation fault

Current thread 0x000003ffa7778b20 (most recent call first):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/btm_matcher.py", line 125 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/refactor.py", line 414 in refactor_tree
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/refactor.py", line 371 in refactor_string
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/refactor.py", line 339 in refactor_file
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/lib2to3/tests/test_all_fixers.py", line 24 in test_all_project_files
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/case.py", line 549 in _callTestMethod
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/case.py", line 592 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/case.py", line 652 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/unittest/runner.py", line 176 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/support/__init__.py", line 959 in _run_suite
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/support/__init__.py", line 1082 in run_unittest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 211 in _test_module
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 236 in _runtest_inner2
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 272 in _runtest_inner
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 155 in _runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/runtest.py", line 195 in runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/main.py", line 319 in rerun_failed_tests
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/main.py", line 696 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/main.py", line 639 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/libregrtest/main.py", line 717 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/test/__main__.py", line 2 in <module>
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/runpy.py", line 87 in _run_code
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/Lib/runpy.py", line 197 in _run_module_as_main
make: *** [Makefile:1199: buildbottest] Segmentation fault (core dumped)

Cannot open file '/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang/build/test-results.xml' for upload

encukou · 2020-10-22T10:54:43Z

Whoa! Doesn't look related but I'll see if I can reproduce that.

bedevere-bot · 2020-10-22T11:25:33Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora LTO 3.x has failed when building commit dde91b1.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/55/builds/240) and take a look at the build logs.
Check if the failure is related to this commit (dde91b1) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/55/builds/240

Failed tests:

test_lib2to3

Summary of the results of the build (if available):

==

Click to see traceback logs

Reset branch 'master'

In function ‘bytearray_removeprefix_impl’,
    inlined from ‘bytearray_removeprefix’ at Objects/clinic/bytearrayobject.c.h:139:20:
Objects/bytearrayobject.c:1204:12: warning: ‘__builtin_memcmp_eq’ specified size between 9223372036854775808 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
 1204 |         && memcmp(self_start, prefix_start, prefix_len) == 0)
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘bytearray_removesuffix_impl’,
    inlined from ‘bytearray_removesuffix’ at Objects/clinic/bytearrayobject.c.h:179:20:
Objects/bytearrayobject.c:1236:12: warning: ‘__builtin_memcmp_eq’ specified size between 9223372036854775808 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
 1236 |         && memcmp(self_start + self_len - suffix_len,
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1237 |                   suffix_start, suffix_len) == 0)
      |                   ~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5696:25,
    inlined from ‘assemble’ at Python/compile.c:6038:18:
Python/compile.c:5612:23: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5612 |             *lnotab++ = 255;
      |             ~~~~~~~~~~^~~~~
Python/compile.c:5613:23: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5613 |             *lnotab++ = 0;
      |             ~~~~~~~~~~^~~
Python/compile.c:5650:19: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5650 |         *lnotab++ = k;
      |         ~~~~~~~~~~^~~
In function ‘bytearray_removeprefix_impl’,
    inlined from ‘bytearray_removeprefix’ at Objects/clinic/bytearrayobject.c.h:139:20:
Objects/bytearrayobject.c:1204:12: warning: ‘__builtin_memcmp_eq’ specified size between 9223372036854775808 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
 1204 |         && memcmp(self_start, prefix_start, prefix_len) == 0)
      |            ^
In function ‘bytearray_removesuffix_impl’,
    inlined from ‘bytearray_removesuffix’ at Objects/clinic/bytearrayobject.c.h:179:20:
Objects/bytearrayobject.c:1236:12: warning: ‘__builtin_memcmp_eq’ specified size between 9223372036854775808 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]
 1236 |         && memcmp(self_start + self_len - suffix_len,
      |            ^
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5696:25,
    inlined from ‘assemble’ at Python/compile.c:6038:18:
Python/compile.c:5612:23: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5612 |             *lnotab++ = 255;
      |                       ^
Python/compile.c:5613:23: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5613 |             *lnotab++ = 0;
      |                       ^
Python/compile.c:5650:19: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5650 |         *lnotab++ = k;
      |                   ^
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5696:0,
    inlined from ‘assemble’ at Python/compile.c:6038:0:
Python/compile.c:5612: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5612 |             *lnotab++ = 255;
      | 
Python/compile.c:5613: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5613 |             *lnotab++ = 0;
      | 
Python/compile.c:5650: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5650 |         *lnotab++ = k;
      | 
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5696:0,
    inlined from ‘assemble’ at Python/compile.c:6038:0:
Python/compile.c:5612: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5612 |             *lnotab++ = 255;
      | 
Python/compile.c:5613: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5613 |             *lnotab++ = 0;
      | 
Python/compile.c:5650: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5650 |         *lnotab++ = k;
      | 
/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Modules/_ctypes/callproc.c: In function ‘_ctypes_callproc’:
/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Modules/_ctypes/callproc.c:857:18: warning: ‘space’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  857 |         space[0] = errno;
      |                  ^
/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Modules/_ctypes/callproc.c:819:10: note: ‘space’ was declared here
  819 |     int *space;
      |          ^~~~~

test_msilib skipped -- No module named '_msi'
Fatal Python error: Segmentation fault

Current thread 0x000003ffbeb78b20 (most recent call first):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/btm_matcher.py", line 125 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/refactor.py", line 458 in refactor_tree
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/refactor.py", line 371 in refactor_string
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/tests/test_fixers.py", line 31 in _check
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/tests/test_fixers.py", line 36 in check
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/tests/test_fixers.py", line 4024 in test_listcomps
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/case.py", line 549 in _callTestMethod
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/case.py", line 592 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/case.py", line 652 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/runner.py", line 176 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/support/__init__.py", line 959 in _run_suite
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/support/__init__.py", line 1082 in run_unittest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 211 in _test_module
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 236 in _runtest_inner2
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 272 in _runtest_inner
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 142 in _runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 195 in runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest_mp.py", line 81 in run_tests_worker
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/main.py", line 659 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/main.py", line 639 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/main.py", line 717 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/regrtest.py", line 43 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/regrtest.py", line 47 in <module>
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/runpy.py", line 87 in _run_code
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/runpy.py", line 197 in _run_module_as_main
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_readline skipped -- No module named 'readline'
test_nis skipped -- No module named 'nis'
test_ossaudiodev skipped -- [Errno 2] No such file or directory: '/dev/dsp'
test_winreg skipped -- No module named 'winreg'
test_devpoll skipped -- test works only on Solaris OS family
test_winsound skipped -- No module named 'winsound'
test_winconsoleio skipped -- test only relevant on win32
test_tix skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_tk skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... ok
test_kqueue (__main__.SelectEINTRTest) ... skipped 'need select.kqueue'
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 6.411s

OK (skipped=2)
test_kqueue skipped -- test works only on BSD
test_ioctl skipped -- Unable to open /dev/tty
test_startfile skipped -- object <module 'os' from '/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/os.py'> has no attribute 'startfile'
test_ttk_guionly skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
Fatal Python error: Segmentation fault

Current thread 0x000003ff80ff8b20 (most recent call first):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/btm_matcher.py", line 125 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/refactor.py", line 414 in refactor_tree
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/refactor.py", line 371 in refactor_string
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/refactor.py", line 339 in refactor_file
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/lib2to3/tests/test_all_fixers.py", line 24 in test_all_project_files
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/case.py", line 549 in _callTestMethod
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/case.py", line 592 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/case.py", line 652 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 122 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/unittest/runner.py", line 176 in run
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/support/__init__.py", line 959 in _run_suite
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/support/__init__.py", line 1082 in run_unittest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 211 in _test_module
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 236 in _runtest_inner2
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 272 in _runtest_inner
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 155 in _runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/runtest.py", line 195 in runtest
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/main.py", line 319 in rerun_failed_tests
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/main.py", line 696 in _main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/main.py", line 639 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/libregrtest/main.py", line 717 in main
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/__main__.py", line 2 in <module>
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/runpy.py", line 87 in _run_code
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/runpy.py", line 197 in _run_module_as_main
make: *** [Makefile:1199: buildbottest] Segmentation fault (core dumped)

Cannot open file '/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/test-results.xml' for upload

Commit 1d541c2 introduced a NULL pointer dereference in error path. Signed-off-by: Christian Heimes <christian@python.org>

bpo-1635741: Fix NULL ptr deref in multiprocessing

beb9443

Commit 1d541c2 introduced a NULL pointer dereference in error path. Signed-off-by: Christian Heimes <christian@python.org>

tiran added the skip news label Oct 22, 2020

the-knights-who-say-ni added the CLA signed label Oct 22, 2020

bedevere-bot added the awaiting core review label Oct 22, 2020

encukou approved these changes Oct 22, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Oct 22, 2020

encukou added the 🤖 automerge label Oct 22, 2020

miss-islington merged commit dde91b1 into python:master Oct 22, 2020

bedevere-bot removed the awaiting merge label Oct 22, 2020

kylotan mannequin mentioned this pull request Sep 19, 2022

Py_Finalize() doesn't clear all Python objects at exit #44470

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-1635741: Fix NULL ptr deref in multiprocessing #22880

bpo-1635741: Fix NULL ptr deref in multiprocessing #22880

tiran commented Oct 22, 2020 •

edited by miss-islington

Loading

bedevere-bot commented Oct 22, 2020

encukou commented Oct 22, 2020

bedevere-bot commented Oct 22, 2020

bpo-1635741: Fix NULL ptr deref in multiprocessing #22880

bpo-1635741: Fix NULL ptr deref in multiprocessing #22880

Conversation

tiran commented Oct 22, 2020 • edited by miss-islington Loading

bedevere-bot commented Oct 22, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

encukou commented Oct 22, 2020

bedevere-bot commented Oct 22, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

tiran commented Oct 22, 2020 •

edited by miss-islington

Loading