Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40077: Convert arraymodule to use heap types and establish module state #23124

Merged
merged 14 commits into from
Jan 2, 2021
Merged

bpo-40077: Convert arraymodule to use heap types and establish module state #23124

merged 14 commits into from
Jan 2, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Nov 3, 2020 •
edited
Loading

Heap types are added to a global state in preparation for module state support.

@corona10 and/or @vstinner, would you mind reviewing this?

https://bugs.python.org/issue40077

@erlend-aasland erlend-aasland marked this pull request as draft November 3, 2020 13:33
@erlend-aasland erlend-aasland marked this pull request as ready for review November 3, 2020 14:08
@erlend-aasland
Copy link
Contributor Author

Ready for review, @corona10 / @vstinner!

vstinner
vstinner reviewed Nov 3, 2020
View reviewed changes
@erlend-aasland erlend-aasland changed the title bpo-40077: Convert arraymodule to use heap types and establish a global state bpo-40077: Convert arraymodule to use heap types and establish module state Nov 3, 2020
vstinner
vstinner reviewed Nov 4, 2020
View reviewed changes
@vstinner vstinner mentioned this pull request Nov 4, 2020
Merged
@erlend-aasland
Copy link
Contributor Author

PTAL, @vstinner. I was thinking about including migrating to PyModule_AddObjectRef as well, but I guess we can do that in a separate PR.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@erlend-aasland
Copy link
Contributor Author

@vstinner Would you mind taking another look at this?

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Dec 19, 2020
encukou
encukou approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do have one nitpick, otherwise the change looks good! Thank you!

@erlend-aasland
Copy link
Contributor Author

PTAL, @encukou

@encukou encukou merged commit 75bf107 into python:master Jan 2, 2021
@erlend-aasland erlend-aasland deleted the bpo-40077/array branch January 2, 2021 16:56
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@adorilson
bpo-40077: Convert arraymodule to use heap types and establish module…
d595e0e 
… state (pythonGH-23124)
@corona10 corona10 mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@encukou encukou encukou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @vstinner @encukou @the-knights-who-say-ni @bedevere-bot