Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-1635741: port pickle to multi-phase init (PEP 489) #23188

Closed
wants to merge 3 commits into from

Conversation

koubaa
Copy link
Contributor

@koubaa koubaa commented Nov 7, 2020

@koubaa
Copy link
Contributor Author

koubaa commented Nov 7, 2020

@vstinner There are more types to convert to heap types. Even so I think these changes are too much and they should be staged in multiple PRs.

I'm wondering how you think I should go about dividing it.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@iritkatriel
Copy link
Member

https://bugs.python.org/issue1635741 is closed. What is the status of this PR?

@vstinner
Copy link
Member

The change is still relevant, but should use a new issue number.

Moreover, the SC asked to put the conversion of static types to heap types on hold. @encukou and @erlend-aasland wrote https://peps.python.org/pep-0687/ which may unblock the situation but it's still a draft.

@erlend-aasland
Copy link
Contributor

@koubaa, PEP 687 was accepted. Are you going to follow up this PR?

@koubaa
Copy link
Contributor Author

koubaa commented Jul 21, 2022

@erlend-aasland I'd love to - but I doubt I will get time in the near term. Others could use my PRs as a reference in case they find it useful towards doing pep 687

@erlend-aasland
Copy link
Contributor

@erlend-aasland I'd love to - but I doubt I will get time in the near term. Others could use my PRs as a reference in case they find it useful towards doing pep 687

All right, I'll pick it up.

Thanks for all your work on isolating extension modules.

@erlend-aasland erlend-aasland self-assigned this Jul 21, 2022
@erlend-aasland
Copy link
Contributor

I'm closing this in order to split it up into multiple PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants