-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-1635741: port pickle to multi-phase init (PEP 489) #23188
Conversation
@vstinner There are more types to convert to heap types. Even so I think these changes are too much and they should be staged in multiple PRs. I'm wondering how you think I should go about dividing it. |
711f040
to
72614d6
Compare
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
https://bugs.python.org/issue1635741 is closed. What is the status of this PR? |
The change is still relevant, but should use a new issue number. Moreover, the SC asked to put the conversion of static types to heap types on hold. @encukou and @erlend-aasland wrote https://peps.python.org/pep-0687/ which may unblock the situation but it's still a draft. |
@koubaa, PEP 687 was accepted. Are you going to follow up this PR? |
@erlend-aasland I'd love to - but I doubt I will get time in the near term. Others could use my PRs as a reference in case they find it useful towards doing pep 687 |
All right, I'll pick it up. Thanks for all your work on isolating extension modules. |
I'm closing this in order to split it up into multiple PRs. |
https://bugs.python.org/issue1635741