-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-41287: Handle doc
argument of property.__init__
in subclasses
#23205
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
c33eb5a
to
73e81e4
Compare
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
unstale |
This PR is stale because it has been open for 30 days with no activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
./python -m test -v test_pydoc
Ran 74 tests in 32.947s
OK (skipped=3)
test_pydoc passed in 33.1 sec
== Tests result: SUCCESS ==
1 test OK.
Total duration: 33.1 sec
Tests result: SUCCESS
cpython on fix-issue41287 [$?] via 🐍 v3.11.0a5+ took 33s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, and sorry this took so long! Unfortunately this needs a merge conflict fixed now. It also needs a NEWS entry.
73e81e4
to
0745f70
Compare
Rebased branch on current |
Misc/NEWS.d/next/Library/2022-04-03-11-25-02.bpo-41287.8CTdwf.rst
Outdated
Show resolved
Hide resolved
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
I think I found the leak. Can we run CI one more time, please? |
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit fb8c2d4 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are the last two things I want to add to this PR:
- add a comment about
prop_doc
and - shortened version for the property branch.
I don't want to disrupt the current CI, so I'll push changes once it finishes.
EDIT: I pushed two more commits when CI reached 81 successful, 1 failure (same as in current main
), and 1 stuck jobs.
@JelleZijlstra Could you please take another look at the PR :) This time everything should be in place. |
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 36fc1b0 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
I triggered the buildbots to make sure, I'll review the PR again tonight. Thanks for your work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few typos in the comments
Fix typos in comments Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Congratulations on your first contribution to Python! |
This breaks subclasses that don't have a writable |
Please see #105262 which restores the behavior this broke. |
Process explicit
doc
argument ofproperty(...)
in the same manner as docstring of getter function in property subclasses.This eliminates behavior differences between dummy
class Property(property): pass
andproperty
(see test case for example)https://bugs.python.org/issue41287