-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.9] bpo-39934: Account for control blocks in 'except' in compiler. (GH-22395) #23303
Conversation
I made this PR manually because there were significant merge conflicts. Please check I got it right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I think you need to change your title to [3.9] bpo-39934: Account for control blocks in 'except' in compiler. (GH-22395)
. And the first message should be:
Pushes an artificial control "block" around the `except` part of a try-except.
This ensures that the computed depth in the compiler matches the actual depth in the runtime.
(cherry picked from commit 02d126aa09d96d03dcf9c5b51c858ce5ef386601 )
This will allow the bots to register it as a backport :). For more info, you can check the devguide section on backporting.
One potential concert may be that ADDOP_JREL
was changed to ADDOP_JUMP
in #21714. Although no behavior should have changed, I hope this doesn't cause problems in the future.
Thanks for doing this. The changes look good to me. |
I've added the news file. I took this up to familiarize myself with the process. If you prefer to to backport we can just close this and the bpo issue. Up to you. |
This is good. I don't need to do it myself. |
Pushes an artificial control "block" around the
except
part of a try-except.This ensures that the computed depth in the compiler matches the actual depth in the runtime.
(cherry picked from commit 02d126a )
https://bugs.python.org/issue39934