-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-1635741: Port _queue to multiphase initialization #23376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I suggest to use PyModule_AddObjectRef() to make the code even better :-)
Signed-off-by: Christian Heimes <christian@python.org>
526b05a
to
c620a61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the update.
@tiran: Status check is done, and it's a success ✅ . |
|
Signed-off-by: Christian Heimes <christian@python.org> Automerge-Triggered-By: GH:tiran
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue1635741
Automerge-Triggered-By: GH:tiran